Skip to content

refactor: update descriptions for resource creation and manifest application in K8s tool#456

Merged
peterj merged 3 commits into
kagent-dev:mainfrom
abhinav-1305:bugfix/misleading-description-create-apply
May 29, 2025
Merged

refactor: update descriptions for resource creation and manifest application in K8s tool#456
peterj merged 3 commits into
kagent-dev:mainfrom
abhinav-1305:bugfix/misleading-description-create-apply

Conversation

@abhinav-1305
Copy link
Copy Markdown
Contributor

Resolves: #454

@peterj peterj merged commit b468298 into kagent-dev:main May 29, 2025
10 checks passed
@abhinav-1305 abhinav-1305 deleted the bugfix/misleading-description-create-apply branch May 30, 2025 01:59
@EdmondDantes21
Copy link
Copy Markdown

EdmondDantes21 commented Jun 9, 2025

Two more lines should be changed in this PR at the functions' definitions, i.e. at def _apply_manifest and def create_resource. I may have made some mistakes, but this PR does not solve the issue for me without these two further adjustments.

@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented Jun 9, 2025

Two more lines should be changed in this PR at the functions' definitions, i.e. at def _apply_manifest and def create_resource. I may have made some mistakes, but this PR does not solve the issue for me without these two further adjustments.

Can you explain in more detail what you mean?

@EdmondDantes21
Copy link
Copy Markdown

Sure, apologies for being so vague.

Currently, the function's signature looks like this:

def _create_resource(
    resource_yaml: Annotated[str, "The YAML definition of the resource to create. Must be a local file"],
    namespace: Annotated[Optional[str], "The namespace of the resource to create"] = None,
) -> str:

The agent still refuses to comply due to that 'Must be a local file'. The same applies to the apply_manifest function.
Btw, are you planning to get rid of built in tools?

@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented Jun 9, 2025

That makes sense, I agree that this probably doesn't fully fix the issue, and yes we are planning to get rid of these built-ins so I don't think it's worth putting too much work into them right now.

Raghavendiran-2002 pushed a commit to Raghavendiran-2002/kagent that referenced this pull request Apr 30, 2026
…-description-create-apply

refactor: update descriptions for resource creation and manifest application in K8s tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] create_resource and apply_manifest functions may have a misleading description

5 participants